Use GCC 11 on CentOS 7

assigned to @aklimov

Blocked by

• build-docker/centos!7 (merged)
• https://git.icinga.com/build-docker/sles/-/merge_requests/2

mentioned in merge request build-docker/centos!7 (merged)

Rationale: https://github.com/Icinga/icinga2/pull/9133

added 1 commit

• 6b92061b - CentOS 7: require devtoolset-11-gcc-c++

Compare with previous version

And now what?

Sigh, does it work when only indenting the lines starting with %?

added 2 commits

• c53f23d6 - CentOS 7: require devtoolset-11-gcc-c++
• c5cb798c - SLES 12.5: require gcc11-c++

Compare with previous version

I opt against.

marked this merge request as ready

unassigned @aklimov

requested review from @jbrost

I gave it a try and it works and I think it looks okay: https://git.icinga.com/packaging/rpm-icinga2/-/blob/2502e8f576dc72f2873a73983fa3f02a666b4d8b/icinga2.spec#L121-143

And then I noticed that other parts of the file are doing that already: https://git.icinga.com/packaging/rpm-icinga2/-/blob/e8649ea33af03df571fb4fb020704c12a6fd2f05/icinga2.spec#L144-186

I mean it's not great and I am somewhat used to that weird indentation style from generating whitespace-sensitive files with Jinja2, but still looks like the best possible option to me.

added 2 commits

• 0a72aa25 - CentOS 7: require devtoolset-11-gcc-c++
• 8fef0c6e - SLES 12.5: require gcc11-c++

Compare with previous version

I've fixed it.

Is the current changeset what you wanted?

@jbrost Was this all you had complaints about or were you going to have another look at this?

I mean looks like it should work, but before I put some testing into this: @htriem what's your opinion on this considering the additional changes this would probably need for the subscription repo base images?