README and attributes clean up

README.md

@@ -60,8 +60,90 @@ https://github.com/Icinga/icinga2client
 - `icinga2client::default` - run_list recipe
 
 
-## Core Attributes
-TODO
+## Cookbook Attributes
+
+* `default['icinga2client']['version']` (default: `2.8.0-X, calculated`): icinga2 package version
+
+* `default['icinga2client']['ignore_version']` (default: `false`): ignore icinga2 package version
+
+* `default['icinga2client']['cookbook']` (default: `icinga2client`): icinga2client resources cookbook name
+
+* `default['icinga2client']['disable_conf_d']` (default: `true`): disable icinga2 `conf.d` default configuration directory in `icinga2.conf` and use LWRP to manage icinga2 objects / templates
+
+* `default['icinga2client']['disable_repository_d']` (default: `false`): disable icinga2 `repository.d` directory in `icinga2.conf`
+
+* `default['icinga2client']['include_itl']` (default: `itl, plugins`): `icinga2.conf` include `itl` array attribute
+
+* `default['icinga2client']['conf_dir']` (default: `/etc/icinga2`): icinga2 configuration location
+
+* `default['icinga2client']['conf_d_dir']` (default: `/etc/icinga2/conf.d`): icinga2 conf.d directory location
+
+* `default['icinga2client']['pki_dir']` (default: `/etc/icinga2/pki`): icinga2 pki directory location
+
+* `default['icinga2client']['scripts_dir']` (default: `/etc/icinga2/scripts`): icinga2 script directory location
+
+* `default['icinga2client']['zones_dir']` (default: `/etc/icinga2/zones.d`): icinga2 zones.d directory location
+
+* `default['icinga2client']['objects_d']` (default: `objects.d`): cookbook created icinga2 Object/Templates resources directory name
+
+* `default['icinga2client']['objects_dir']` (default: `/etc/icinga2/objects.d`): cookbook created icinga2 Object/Templates resources directory location
+
+* `default['icinga2client']['user_defined_objects_dir']` (default: `['user_defined_objects']`): user defined configuration directories, each directory is included in `icinga2.conf` file.
+
+* `default['icinga2client']['features_enabled_dir']` (default: `/etc/icinga2/features-enabled`): icinga2 enabled features location
+
+* `default['icinga2client']['features_available_dir']` (default: `/etc/icinga2/features-available`): icinga2 available features location
+
+* `default['icinga2client']['databag']` (default: `icinga2`): icinga2 databag name, currently not used
+
+* `default['icinga2client']['var_dir']` (default: `calculated`): icinga2 run directory
+
+* `default['icinga2client']['run_dir']` (default: `/var/run/icinga2`): icinga2 run directory
+
+* `default['icinga2client']['run_cmd_dir']` (default: `/var/run/icinga2/cmd`): icinga2 location for process `icinga2.cmd`
+
+* `default['icinga2client']['cache_dir']` (default: `/var/cache/icinga2`): icinga2 cache directory location
+
+* `default['icinga2client']['spool_dir']` (default: `/var/spool/icinga2`): icinga2 spool directory location
+
+* `default['icinga2client']['perfdata_dir']` (default: `/var/spool/icinga2/perfdata`): icinga2 perfdata directory location
+
+* `default['icinga2client']['lib_dir']` (default: `/var/lib/icinga2`): icinga2 lib directory location
+
+* `default['icinga2client']['log_dir']` (default: `/var/log/icinga2`): icinga2 core process log directory location
+
+* `default['icinga2client']['cache_dir']` (default: `/var/cache/icinga2`): icinga2 cache directory location
+
+* `default['icinga2client']['service_name']` (default: `icinga2`): icinga2 process name
+
+* `default['icinga2client']['service_config_file']` (default: `/etc/default/icinga2`): icinga2 * process configuration file
+
+* `default['icinga2client']['plugins_dir']` (default: `/usr/lib/nagios/plugins`): icinga2 plugins directory location
+
+* `default['icinga2client']['custom_plugins_dir']` (default: `/opt/icinga2_custom_plugins`): icinga2 custom plugins directory
+
+* `default['icinga2client']['admin_user']` (default: `icingaadmin`): icinga2 admin user
+
+* `default['icinga2client']['user']` (default: `icinga`): icinga2 user
+
+* `default['icinga2client']['group']` (default: `icinga`): icinga2 user group
+
+* `default['icinga2client']['cmdgroup']` (default: `icingacmd`): icinga2 cmd user group
+
+* `default['icinga2client']['endpoint_port']` (default: `5665`): icinga2 endpoint port
+
+* `default['icinga2client']['version_suffix']` (default: `calculated`): icinga2 package suffix
+
+
+## Cookbook Icinga2 Constants Attributes
+
+* `default['icinga2client']['constants']['NodeName']` (default: `node['fqdn']`): icinga2 NodeName constant
+
+* `default['icinga2client']['constants']['PluginDir']` (default: `node['icinga2']['plugins_dir']`): icinga2 plugins directory location
+
+* `default['icinga2client']['constants']['ManubulonPluginDir']` (default: `node['icinga2']['plugins_dir']`): icinga2 plugins directory location
+
+* `default['icinga2client']['constants']['TicketSalt']` (default: `ed25aed394c4bf7d236b347bb67df466`): icinga2 default TicketSalt key
 
 
 ## Contributing

attributes/default.rb

@@ -8,8 +8,6 @@ default['icinga2client']['version'] = value_for_platform(
   %w[windows] => { 'default' => '2.8.0' }
 )
 
-default['icinga2client']['enable_env_pki'] = false
-default['icinga2client']['enable_env_custom_pki'] = false
 default['icinga2client']['ignore_version'] = false
 default['icinga2client']['cookbook'] = 'icinga2client'
 
@@ -35,34 +33,15 @@ default['icinga2client']['include_itl'] = if node['platform'] == 'windows'
                                             %w[itl plugins]
                                           end
 
-# includes yum-epel cookbook to setup yum epel repository
-default['icinga2client']['setup_epel'] = true
-
 # object conf file location
 default['icinga2client']['objects_d'] = 'objects.d'
 default['icinga2client']['objects_dir'] = ::File.join(node['icinga2client']['conf_dir'], node['icinga2client']['objects_d'])
 
 # user defined icing2 object / configuration
 default['icinga2client']['user_defined_objects_dir'] = %w[user_defined_objects]
-
 default['icinga2client']['features_enabled_dir'] = ::File.join(node['icinga2client']['conf_dir'], 'features-enabled')
 default['icinga2client']['features_available_dir'] = ::File.join(node['icinga2client']['conf_dir'], 'features-available')
 
-default['icinga2client']['cluster_attribute'] = nil
-default['icinga2client']['application_attribute'] = nil
-default['icinga2client']['enable_cluster_hostgroup'] = true
-default['icinga2client']['enable_application_hostgroup'] = true
-default['icinga2client']['enable_role_hostgroup'] = false
-default['icinga2client']['limit_region'] = true
-
-# host attribute to use for Host Object
-# attribute display_name in LWRP environment
-default['icinga2client']['host_display_name_attr'] = 'hostname'
-default['icinga2client']['use_fqdn_resolv'] = false
-default['icinga2client']['failover_fqdn_address'] = true
-default['icinga2client']['ignore_node_error'] = false
-default['icinga2client']['ignore_resolv_error'] = true
-
 # icinga2 resources data bag
 default['icinga2client']['databag'] = 'icinga2client'
 
@@ -80,7 +59,6 @@ default['icinga2client']['spool_dir'] = ::File.join(node['icinga2client']['var_d
 default['icinga2client']['perfdata_dir'] = ::File.join(node['icinga2client']['var_dir'], 'spool/icinga2/perfdata')
 default['icinga2client']['lib_dir'] = ::File.join(node['icinga2client']['var_dir'], 'lib/icinga2')
 default['icinga2client']['log_dir'] = ::File.join(node['icinga2client']['var_dir'], 'log/icinga2')
-default['icinga2client']['cache_dir'] = ::File.join(node['icinga2client']['var_dir'], 'cache/icinga2')
 default['icinga2client']['service_name'] = 'icinga2'
 
 case node['platform_family']
@@ -118,11 +96,6 @@ default['icinga2client']['custom_plugins_dir'] = if node['platform'] == 'windows
 default['icinga2client']['admin_user'] = 'icingaadmin'
 default['icinga2client']['endpoint_port'] = 5665
 
-# ulimit
-default['icinga2client']['limits']['memlock']    = 'unlimited'
-default['icinga2client']['limits']['nofile']     = 48_000
-default['icinga2client']['limits']['nproc']      = 'unlimited'
-
 # version suffix
 case node['platform']
 when 'centos', 'redhat', 'fedora', 'amazon'
@@ -140,24 +113,3 @@ default['icinga2client']['constants']['NodeName'] = node['fqdn']
 default['icinga2client']['constants']['PluginDir'] = node['icinga2client']['plugins_dir']
 default['icinga2client']['constants']['ManubulonPluginDir'] = node['icinga2client']['plugins_dir']
 default['icinga2client']['constants']['TicketSalt'] = 'ed25aed394c4bf7d236b347bb67df466'
-
-# objects
-default['icinga2client']['server']['object']['global-templates'] = false
-default['icinga2client']['server']['object']['host']['import'] = 'generic-host'
-default['icinga2client']['server']['object']['host']['max_check_attempts'] = 3
-default['icinga2client']['server']['object']['host']['check_period'] = nil
-default['icinga2client']['server']['object']['host']['notification_period'] = nil
-default['icinga2client']['server']['object']['host']['check_interval'] = '1m'
-default['icinga2client']['server']['object']['host']['retry_interval'] = '30s'
-default['icinga2client']['server']['object']['host']['enable_notifications'] = true
-default['icinga2client']['server']['object']['host']['enable_active_checks'] = true
-default['icinga2client']['server']['object']['host']['enable_passive_checks'] = false
-default['icinga2client']['server']['object']['host']['enable_event_handler'] = true
-default['icinga2client']['server']['object']['host']['enable_flapping'] = true
-default['icinga2client']['server']['object']['host']['enable_perfdata'] = true
-default['icinga2client']['server']['object']['host']['event_command'] = nil
-default['icinga2client']['server']['object']['host']['flapping_threshold'] = nil
-default['icinga2client']['server']['object']['host']['volatile'] = nil
-default['icinga2client']['server']['object']['host']['check_command'] = 'hostalive'
-default['icinga2client']['server']['object']['host']['zone'] = nil
-default['icinga2client']['server']['object']['host']['command_endpoint'] = nil