From fd72c7d8b7c0b8eff7569725533370b98e703177 Mon Sep 17 00:00:00 2001
From: Assaf Flatto <assaf@aikilinux.com>
Date: Wed, 14 Mar 2018 16:56:29 +0200
Subject: [PATCH] Fix nrpe configuration - allowed hosts IP detection

---
 icinga2-ansible-add-hosts/defaults/main.yml   |  2 +-
 icinga2-ansible-add-hosts/tasks/main.yml      |  9 ++++++++
 icinga2-nrpe-agent/defaults/main.yml          |  2 ++
 .../tasks/icinga2_nrpe_agent_Debian.yml       | 22 ++++++++++---------
 icinga2-nrpe-agent/tasks/main.yml             |  4 ++++
 icinga2-nrpe-agent/templates/nrpe.cfg.j2      |  2 +-
 6 files changed, 29 insertions(+), 12 deletions(-)

diff --git a/icinga2-ansible-add-hosts/defaults/main.yml b/icinga2-ansible-add-hosts/defaults/main.yml
index ca6e257..f386f96 100644
--- a/icinga2-ansible-add-hosts/defaults/main.yml
+++ b/icinga2-ansible-add-hosts/defaults/main.yml
@@ -1,7 +1,7 @@
 ---
 # defaults file for icinga2-ansible-add-hosts
 
-icinga2_hosts_dir: "/etc/icinga2/conf.d/"
+icinga2_hosts_dir: "/etc/icinga2/conf.d/hosts"
 host_address: "{{ hostvars[item]['ansible_default_ipv4']['address'] }}"
 host_attributes: "none"
 host_checks: "none"
diff --git a/icinga2-ansible-add-hosts/tasks/main.yml b/icinga2-ansible-add-hosts/tasks/main.yml
index 3c41810..d6c9d0f 100644
--- a/icinga2-ansible-add-hosts/tasks/main.yml
+++ b/icinga2-ansible-add-hosts/tasks/main.yml
@@ -1,4 +1,13 @@
 ---
 # tasks file for icinga2-ansible-add-hosts
 
+- name: create Autogenerated host directory
+  file:
+      path: "{{ icinga2_hosts_dir }}"
+      owner: icinga
+      group: icinga
+      mode: 0755
+      state: directory
+      recurse: yes
+
 - import_tasks: icinga2_add_hosts.yml
diff --git a/icinga2-nrpe-agent/defaults/main.yml b/icinga2-nrpe-agent/defaults/main.yml
index 86ce672..cbc7043 100644
--- a/icinga2-nrpe-agent/defaults/main.yml
+++ b/icinga2-nrpe-agent/defaults/main.yml
@@ -24,6 +24,8 @@ nrpe_agent_plugins_x86_64: "/usr/lib64/nagios/plugins"
 
 nrpe_agent_check_mem: "https://raw.githubusercontent.com/zwindler/check_mem_ng/master/check_mem_ng.sh"
 
+ssh_port: 22
+
 # Sample NRPE check commands
 nrpe_check_commands:
   check_load:
diff --git a/icinga2-nrpe-agent/tasks/icinga2_nrpe_agent_Debian.yml b/icinga2-nrpe-agent/tasks/icinga2_nrpe_agent_Debian.yml
index 5605d40..d91f763 100644
--- a/icinga2-nrpe-agent/tasks/icinga2_nrpe_agent_Debian.yml
+++ b/icinga2-nrpe-agent/tasks/icinga2_nrpe_agent_Debian.yml
@@ -1,20 +1,22 @@
 ---
 - name: Install Nrpe and Plugins
-  apt: pkg={{ item }} 
-       state=latest
-       update_cache=yes
-       install_recommends=no
+  package:
+       name: "{{ item }}"
+       state: latest
+       update_cache: yes
+       install_recommends: no
   with_items: "{{ nrpe_agent_Debian }}"
   tags:
    - nrpe_agent_install
 
 - name: Copy Nrpe Configuration
-  template: src=nrpe.cfg.j2
-            dest={{ nrpe_agent_config }}
-            owner=root
-            group=root
-            mode=0644
-            backup=yes
+  template:
+    src: nrpe.cfg.j2
+    dest: "{{ nrpe_agent_config }}"
+    owner: root
+    group: root
+    mode: 0644
+    backup: yes
   notify:
    - restart nagios-nrpe-server
   tags:
diff --git a/icinga2-nrpe-agent/tasks/main.yml b/icinga2-nrpe-agent/tasks/main.yml
index 45ab161..b70bbda 100644
--- a/icinga2-nrpe-agent/tasks/main.yml
+++ b/icinga2-nrpe-agent/tasks/main.yml
@@ -1,6 +1,10 @@
 ---
 # tasks file for icinga2-nrpe-agent
 
+- set_fact:
+    allowed_hosts: "{{ hostvars[item]['ansible_default_ipv4']['address'] }}"
+  with_inventory_hostnames: monitoring_servers
+
 - include_tasks: icinga2_nrpe_agent_RedHat.yml
   when: ansible_os_family == 'RedHat' and 'monitoring_servers' not in group_names
   # NRPE Agent will be installed on clients only
diff --git a/icinga2-nrpe-agent/templates/nrpe.cfg.j2 b/icinga2-nrpe-agent/templates/nrpe.cfg.j2
index dcfc6d3..7cab60b 100644
--- a/icinga2-nrpe-agent/templates/nrpe.cfg.j2
+++ b/icinga2-nrpe-agent/templates/nrpe.cfg.j2
@@ -1,6 +1,6 @@
 # {{ ansible_managed }}
 
-allowed_hosts={{ nrpe_allowed_hosts }}
+allowed_hosts={{ allowed_hosts | default('nrpe_allowed_hosts') }}
 
 {{ nrpe_configuration }}
 
-- 
GitLab